Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 7.0.14 #36238

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 7.0.14 #36238

wants to merge 1 commit into from

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Nov 23, 2020

7.0.14 (2020-11-23)

DEPENDENCIES

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Nov 23, 2020
@ruyadorno ruyadorno added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34522/

@MylesBorins MylesBorins added request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 23, 2020
@MylesBorins
Copy link
Contributor

can we please fast-track?

@MylesBorins
Copy link
Contributor

@codebytere please include this in tomorrow's 15.x release. I'll work on making sure it is landed. Failed tests are due to master being broken

@MylesBorins
Copy link
Contributor

In an attempt to fix CI I've rebased out a couple of commits from master, fingers crossed that we can get a green CI

@MylesBorins MylesBorins added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34524/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34526/

@Trott
Copy link
Member

Trott commented Nov 24, 2020

Fix to CI issues has landed, so I'm running a fresh CI. Should be green or green-ish. I'll try to stay up until this lands. (It's not late here, but uh...yeah, I keep early hours these days.)

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34528/

@MylesBorins
Copy link
Contributor

rebased and kicked off another CI, hopefully fixes broken actions

MylesBorins
MylesBorins approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

codebytere pushed a commit that referenced this pull request Nov 24, 2020
@nlf @codebytere
deps: upgrade npm to 7.0.14
4a88c73 
PR-URL: #36238
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 24, 2020

Landed in 767070c

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 24, 2020
@nlf @Trott
deps: upgrade npm to 7.0.14
767070c 
PR-URL: nodejs#36238
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@Trott Trott closed this Nov 24, 2020
@bricss bricss mentioned this pull request Nov 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@codebytere codebytere codebytere approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nlf @nodejs-github-bot @MylesBorins @Trott @ruyadorno @lpinca @codebytere @cjihrig @aduh95